From 9463ca4dcd82bbbcd81bd954d8b57c5de7548b94 Mon Sep 17 00:00:00 2001 From: alessandro Date: Wed, 1 Nov 2017 00:54:47 +0100 Subject: [PATCH] use hash for ftp params --- LoadCSVData.pl | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/LoadCSVData.pl b/LoadCSVData.pl index ecbafb3..9866fc5 100644 --- a/LoadCSVData.pl +++ b/LoadCSVData.pl @@ -180,16 +180,21 @@ sub trxelab { $dbh->disconnect; $ftp_parm //= ""; - if ( $ftp_parm ne "" ) { - $ftp_parm = "Debug=>0, " . $ftp_parm; - } - else { - $ftp_parm = "Debug=>0"; + $ftp_parm =~ s/\s//g; + + my %ftp_parms = ( + 'Host' => $ftp_addrs, + ); + + foreach my $parm (split(/,/, $ftp_parm)) + { + my ($key, $val) = split(/=>/, $parm); + $ftp_parms{$key} = $val; } - print getTimeStamp("log") . " - pid $$ >> $tool: ftp parm = $ftp_parm.\n"; + print getTimeStamp("log") . " - pid $$ >> $tool: ftp parm = " . Dumper(%ftp_parms) . "\n"; - my $ftp = Net::FTP->new( Host=>$ftp_addrs, $ftp_parm ) + my $ftp = Net::FTP->new( %ftp_parms ) or die getTimeStamp("log") . " - pid $$ >> Cannot connect to $ftp_addrs: $@ \n"; $ftp->login( $ftp_user, $ftp_passwd )